{"author":"Amrit Sahu","author_email":"88420255+sahamrit@users.noreply.github.com","author_time":1701712013,"commit_time":1701712013,"committer":"GitHub","committer_email":"noreply@github.com","hash":"e8d6a6ef2e6c5ef9d87a9be3308a0cd90778217d","message":"view.reshape without symbolic (#2218)\n\n* handle reshape of contiguous subparts with explicit mask\r\n\r\n* remove the add/remove ones logic in reshape\r\n\r\n* accomodate ones in accumulate logic\r\n\r\n* make multiply commutative\r\n\r\n* fix linting\r\n\r\n* make mypy happy\r\n\r\n* add test for commutative mul\r\n\r\n* merge dimensions in shape_strides for 1 range masks\r\n\r\n* add offsets for merging\r\n\r\n* fix linting\r\n\r\n* add back explicit 1 reshapes\r\n\r\n* fix mypy errors\r\n\r\n* fix accumulate by includng state\r\n\r\n* include non-zero stride dimension in acc\r\n\r\n* small cleanup\r\n\r\n* more compact to_shape_strides\r\n\r\n* more logical cleanup\r\n\r\n* compress more\r\n\r\n* compress reshape mask\r\n\r\n* adding some comments\r\n\r\n* small bug fix\r\n\r\n* improve test coverage\r\n\r\n* remove explicit add remove ones\r\n\r\n* small bug in test\r\n\r\n* enable test_reshape_splitting_combining\r\n\r\n* small fix\r\n\r\n* 10 lines less to_shape_strides\r\n\r\n* shorten reshape mask\r\n\r\n* some more cleanup\r\n\r\n* more cleanup\r\n\r\n* introduce some symbols for compactness\r\n\r\n* more symbols\r\n\r\n* more cleaner\r\n\r\n* lessen symbols, it became less readable\r\n\r\n* remove merge_views from view.reshape\r\n\r\n* change to_shape_strides to _merge_dims\r\n\r\n* improve readability\r\n\r\n* fix corner case\r\n\r\n* cleanup\r\n\r\n* better handling of 1 <= Variable('i',1,10) & new_dim = Variable('i',1,10)\r\n\r\n* rewrite _reshape_mask for readability\r\n\r\n* fix white space\r\n\r\n* add comment\r\n\r\n* nice shorthands for readability\r\n\r\n* add proof in docs\r\n\r\n* small nit\r\n\r\n---------\r\n\r\nCo-authored-by: chenyu <chenyu@fastmail.com>","parents":["664475f2479d2d54121314bfa1117698fc989e9e"],"tree_hash":"1a7caa45dba391a407ed92f1f38775c005c29cc2"}