{"author":"Joel Depooter","author_email":"joel.depooter@safe.com","author_time":1750459442,"commit_time":1750495871,"committer":"Daniel Stenberg","committer_email":"daniel@haxx.se","hash":"e3d9675924325bda60ff44510ada012d47962cde","message":"libssh: fix incorrect return value in myssh_in_AUTH_PKEY_INIT\n\nIn the unlikely case that no SSH auth methods are supported, the\nprevious code would return 0 from myssh_in_AUTH_PKEY_INIT. However,\nfollowing the code path, it seems like it should be returning SSH_ERROR,\nas set in myssh_to_ERROR (through myssh_to_GSSAPI_AUTH,\nmyssh_to_KEY_AUTH and myssh_to_PASSWD_AUTH).\n\nIn actuality, this is unlikely to occur, as the similar code in\nmyssh_in_AUTHLIST would have already returned an error in this scenario.\nHowever setting a return value and then ignoring it is a bit fishy and\nshould be documented if this is intended.\n\nI believe this used to return an error, but was changed in the recent\nre-factoring of this code.\n\nCloses #17691\n","parents":["7d8fa8276d4df7a89056ef4bfd1fee47efd56aa6"],"tree_hash":"339bff7c19a6d4595dda44467cedede35ecc260e"}