{"author":"Viktor Szakats","author_email":"commit@vsz.me","author_time":1750555053,"commit_time":1750626526,"committer":"Viktor Szakats","committer_email":"commit@vsz.me","hash":"e088e104549421914da9170eeead72a43d42c028","message":"cmake: replace the way clang-tidy verifies tests, fix issues found\n\nReplace existing `mk-unity.pl` `--embed` workaround with running\n`clang-tidy` manually on individual test source instead. This aligns\nwith how clang-tidy works and removes `mk-unity.pl` from the solution.\n\nAlso:\n- mqttd: fix potentially uninitialized buffer by zero filling it.\n  ```\n  tests/server/mqttd.c:484:41: error: The left operand of '<<' is a garbage value\n    [clang-analyzer-core.UndefinedBinaryOperatorResult,-warnings-as-errors]\n    484 |       payload_len = (size_t)(buffer[10] << 8) | buffer[11];\n        |                                         ^\n  [...]\n  tests/server/mqttd.c:606:45: error: The left operand of '<<' is a garbage value\n    [clang-analyzer-core.UndefinedBinaryOperatorResult,-warnings-as-errors]\n    606 |       topiclen = (size_t)(buffer[1 + bytes] << 8) | buffer[2 + bytes];\n        |                                             ^\n  ```\n- sockfilt: fix potential out-of-bound pointer:\n  ```\n  tests/server/sockfilt.c:1128:33: error: The 2nd argument to 'send' is a buffer\n     with size 17010 but should be a buffer with size equal to or greater than\n     the value of the 3rd argument (which is 18446744073709551615)\n     [clang-analyzer-unix.StdCLibraryFunctions,-warnings-as-errors]\n   1128 |         ssize_t bytes_written = swrite(sockfd, buffer, buffer_len);\n        |                                 ^\n  ```\n- clang-tidy: suppress bogus `bzero()` warnings that happens\n  inside the notorious `FD_ZERO()` macros, on macOS.\n\nRef: https://github.com/curl/curl/pull/17680#issuecomment-2991730158\n\nCloses #17705\n","parents":["9837dd429a0998341aaf70b377f17506a7e9f0d5"],"tree_hash":"38fa162972c0143a6eef55c8b7b9488e43ffd4a6"}