{"author":"Viktor Szakats","author_email":"commit@vsz.me","author_time":1740410738,"commit_time":1740427231,"committer":"Viktor Szakats","committer_email":"commit@vsz.me","hash":"9b0467b169e08b70077f09313975d4eac14a9930","message":"windows: drop code and curl manifest targeting W2K and older\n\ncurl requires Windows XP since 2023. Drop version detection code using\n`GetVersionEx()` aimed to support earlier Windows versions. With that\ncall deleted, the embedded manifest in `curl.rc` becomes unnecessary.\nDelete it too, along with the enabler logic in build systems.\n\nThis allows to stop forcing `/MANIFEST:NO` for MSVC builds. Dropping it\nfixes VS2008 shared builds, that require an auto-generated SxS\n(side-by-side assembly) manifest to find their CRT DLLs. This was the\nissue that prevented VS2008 `curl.exe` launching on AppVeyor CI:\n```\nsrc/curl.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory\n```\nRef: https://ci.appveyor.com/project/curlorg/curl/builds/51577006/job/eitypvwlb1rxr11d#L261\n\nFWIW the `curl.rc` embedded manifest wasn't ever enabled for VS2008 CI\nbuilds either, because CMake did not pass our custom macro via\n`CMAKE_RC_FLAGS` to `rc.exe`. For reasons I could not figure out.\n\nAfter this patch the curl build no longer inject its own manifest, and\nlets the default be applied by linkers and toolchains. It fixes VS2008\nshared builds. curl continues to detect the real Windows version via\n`RtlVerifyVersionInfo()` from `ntdll`.\n\nFollow-up to 960d601481eed46d7b46391380c4869bcf0d9f19 #12225\nFollow-up to 5044909ca251d3d190d8c5cc45243a04d244eaed #7810\nFollow-up to ebd213270a017a6830928ee2e1f4a9cabc799898 #1221\nRef: #15972\nCherry-picked from #16394\n\nCloses #16453\n","parents":["3585796049aa5c8cc2ef4e4fa3ac289b0d5ed85c"],"tree_hash":"c3080197d9f129be51893dfc89b5868f6325cfc0"}