{"author":"Viktor Szakats","author_email":"commit@vsz.me","author_time":1741230803,"commit_time":1741288169,"committer":"Viktor Szakats","committer_email":"commit@vsz.me","hash":"9463769f2e2dba9eeff554a88e5df5195d2c774b","message":"tests: reformat error messages to avoid tripping MSBuild\n\nChange the format of error messages sent to stderr from tests and test\nservers. As a workaround to avoid triggering Visual Studio's MSBuild\ntool's built-in regexp matcher, and making it mark builds failed for\nreasons we don't want them to hard fail.\n\nRoughly, the pattern to avoid is the word \"error\" (case-insensitive)\nin the same line with a colon `:`.\n\nIt affected GHA/windows MSVC CI jobs, causing flakiness:\n```\nCUSTOMBUILD : fopen() failed with error : 13 Permission denied [D:\\a\\curl\\curl\\bld\\tests\\test-ci.vcxproj]\n  Error opening file: log/4/smtp_sockfilt.log\n[...]\nCUSTOMBUILD : fopen() failed with error : 13 Permission denied [D:\\a\\curl\\curl\\bld\\tests\\test-ci.vcxproj]\n  Error opening file: log/8/imap_sockfilt.log\n  Msg not logged: 00:18:10.656000 > 178 bytes data, server => client\n[...]\n  TESTDONE: 1629 tests out of 1634 reported OK: 99%\n  Building Custom Rule D:/a/curl/curl/tests/CMakeLists.txt\nC:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\MSBuild\\Microsoft\\VC\\v170\\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for 'D:\\a\\curl\\curl\\bld\\CMakeFiles\\621f80ddbb0fa48179f056ca77842ff0\\test-ci.rule;D:\\a\\curl\\curl\\tests\\CMakeLists.txt' exited with code -1. [D:\\a\\curl\\curl\\bld\\tests\\test-ci.vcxproj]\nError: Process completed with exit code 1.\n```\nRef: https://github.com/curl/curl/actions/runs/13643149623/job/38137076210?pr=16490#step:14:3125\nRef: https://github.com/curl/curl/actions/runs/13688765792/job/38277961720?pr=16582#step:14:1717\n\nThe `IgnoreStandardErrorWarningFormat=\"true\"` MSBuild Exec option\ncontrols this behavior:\nhttps://learn.microsoft.com/visualstudio/msbuild/exec-task#parameters\nI couldn't figure out a way to apply it to CMake builds.\n\nMSBuid pattern matching rules:\nhttps://github.com/dotnet/msbuild/blob/353c0f3d37957cc98bfa6a76b568d70d12193fc3/src/Shared/CanonicalError.cs\nhttps://learn.microsoft.com/visualstudio/msbuild/msbuild-diagnostic-format-for-tasks\n\nNote: There may be further error messages output from runtests scripts,\nthat use this format, which are not explicitly fatal. They may need\nfuture fixes.\n\nThanks-to: Dion Williams\nRef: https://github.com/curl/curl/discussions/14854#discussioncomment-12382190\nRef: https://github.com/curl/curl/discussions/14854#discussioncomment-12395224\n\nCloses #16583\n","parents":["8537a5b0bcf4565551774c2b2375c49767e405a7"],"tree_hash":"9dcd4d3577ae398f9ecfbc1360cb8a25a3f9b422"}